Skip to content

Clean up commented out callback_url, seemingly unnecessary query_string #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aguynamedben wants to merge 1 commit into
base: commande-tweaks
Choose a base branch
from
Open

Clean up commented out callback_url, seemingly unnecessary query_string #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions lib/omniauth-notion.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ class Notion < OmniAuth::Strategies::OAuth2
end

extra do
{
'raw_info' => raw_info
}
{ 'raw_info' => raw_info }
end

# The Notion API requires HTTP Basic Authentication when exchanging the
Expand Down Expand Up @@ -70,32 +68,6 @@ def raw_info
def callback_url
full_host + script_name + callback_path
end

# def callback_url
# if @authorization_code_from_signed_request
# ''
# else
# options[:callback_url] || super
# end
# end

# def callback_url
# # If redirect_uri is configured in token_params, use that
# # value.
# token_params.to_hash(symbolize_keys: true)[:redirect_uri] || super
# end

def query_string
# This method is called by callback_url, only if redirect_uri
# is omitted in token_params.
if request.params['code']
# If this is a callback, ignore query parameters added by
# the provider.
''
else
super
end
end
end
end
end