fix: gates mallinfo for linux only.#1045
Open
jaoleal wants to merge 1 commit into
Open
Conversation
Before this commit, the linux-specific mallinfo could be exposed to windows.
jaoleal
added
bug
Member
|
Out of curiosity: if you do compile to windows, does it compile and return all zeroes when running this RPC? |
Member
Author
I wish i had a Windows machine to test that |
Member
Docker + Cross.toml edit: VMs are a thing too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
Before this commit, the linux-specific mallinfo could be exposed to windows when compiled with the gnu toolchain.
How to verify the changes you have done?
You pretty much have to compile for windows with the gnu toolchain.
In my machine i did that using floresta-nix.
This post may help you to achieve that.