Skip to content

Add alt attribute on blog logo and on banner images #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BirdKeyboard wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add alt attribute on blog logo and on banner images #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/summerb146.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ var summer = (function ($) {
},

postHeaderCoverImg = function () {
var coverImage = $('[alt=cover-image]');
var coverImage = $('#cover-image');
if (coverImage.length) {
$(postCoverImg).append('<img src="' + coverImage.attr('src') + '">');
$(postCoverImg).append('<img src="' + coverImage.attr('src') + '" alt="' + coverImage.attr('alt') + '">');
coverImage.remove();
}
},
Expand Down
2 changes: 1 addition & 1 deletion templates/categories.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<header class="summer-page-header">
<div class="summer-page-menu-header">
<a class="summer-blog-logo" href="{{ base_url_absolute }}">
<img src="{{ base_url_relative }}{{ site.logo }}" alt="Blog Logo" />
<img src="{{ base_url_relative }}{{ site.logo }}" alt="{{ site.title }}" />
</a>

{% include 'partials/navigation.html.twig' %}
Expand Down
2 changes: 1 addition & 1 deletion templates/featured.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<header class="summer-page-header">
<div class="summer-page-menu-header">
<a class="summer-blog-logo" href="{{ base_url_absolute }}">
<img src="{{ base_url_relative }}{{ site.logo }}" alt="Blog Logo" />
<img src="{{ base_url_relative }}{{ site.logo }}" alt="{{ site.title }}" />
</a>

{% include 'partials/navigation.html.twig' %}
Expand Down
2 changes: 1 addition & 1 deletion templates/page.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<header class="summer-page-header">
<div class="summer-page-menu-header">
<a class="summer-blog-logo" href="{{ basebase_url_absolute_url }}">
<img src="{{ base_url }}{{ site.logo }}" alt="Blog Logo" /></a>
<img src="{{ base_url }}{{ site.logo }}" alt="{{ site.title }}" /></a>
</a>

{% include 'partials/navigation.html.twig' %}
Expand Down
2 changes: 1 addition & 1 deletion templates/partials/base.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
{% block header %}
<header class="summer-site-head">
<div class="summer-site-head-menu">
<a class="summer-blog-logo" href="{{ base_url == '' ? '/' : base_url }}"><img src="{{ base_url_relative }}{{ site.logo }}" alt="Blog Logo" /></a>
<a class="summer-blog-logo" href="{{ base_url == '' ? '/' : base_url }}"><img src="{{ base_url_relative }}{{ site.logo }}" alt="{{ site.title }}" /></a>
{% include 'partials/navigation.html.twig' %}
<div class="clearfix"></div>
</div>
Expand Down
10 changes: 8 additions & 2 deletions templates/post.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@
{% block header %}{% endblock %}

{% block content %}

<main id="summer-post-container" class="summer-post-container intro-effect-sliced" role="main">
<header class="summer-post-header">
<div class="bg-img"></div>
<div class="summer-post-menu-header">
<a class="summer-blog-logo" href="{{ base_url_absolute }}">
<img src="{{ base_url }}{{ site.logo }}" alt="Blog Logo" />
<img src="{{ base_url }}{{ site.logo }}" alt="{{ site.title }}" />
</a>
{% include 'partials/navigation.html.twig' %}
</div>
Expand All @@ -24,7 +25,12 @@

<button class="trigger bg-check" data-info="Read more"><span>Trigger</span></button>

{% if page.header.image %}<img src="{{ page.media[page.header.image].url }}" alt="cover-image" />{% endif %}
{% set headerAlt = page.title %}
{% if page.header.imageAlt %}
{% set headerAlt = page.header.imageAlt %}
{% endif %}

{% if page.header.image %}<img src="{{ page.media[page.header.image].url }}" id="cover-image" alt="{{ headerAlt }}" />{% endif %}

<article class="summer-post-content post">
<div>
Expand Down