misc(customer): Expose error_details on API#383
Merged
vincent-pochet merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Python client + test fixtures to surface error_details on customer-related API responses (aligned with the upstream lago-api / OpenAPI changes), and updates the error detail model to match the payload shape.
Changes:
- Add
error_detailsto theCustomerResponsemodel. - Update
ErrorDetailResponseto uselago_id(instead oforganization_id). - Update JSON fixtures (
customer.json,invoice.json) to includeerror_detailsand apply minor formatting changes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/fixtures/invoice.json | Adds an error_details array to the invoice fixture and minor JSON formatting tweaks. |
| tests/fixtures/customer.json | Adds an error_details array to the customer fixture and minor JSON formatting tweaks. |
| lago_python_client/models/error_detail.py | Renames organization_id → lago_id on ErrorDetailResponse. |
| lago_python_client/models/customer.py | Exposes error_details on CustomerResponse (typed as ErrorDetailsResponse). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
annvelents
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to
It exposes the
error_detailson the customer related end-points