refactor(mcp): conv_send_voice_sms_channel_test is SMS-only - #708
Open
kmonsoe wants to merge 2 commits into
Open
refactor(mcp): conv_send_voice_sms_channel_test is SMS-only#708kmonsoe wants to merge 2 commits into
kmonsoe wants to merge 2 commits into
Conversation
The send path dispatches on capabilities.sendTest, which only Twilio and MessageBird set. Vapi and Threll declare sendTest: false, so a voice channel has always answered "does not support test sends" — the voice_sms qualifier promised a path that does not exist. Its sibling conv_test_voice_sms_channel keeps the qualifier: every vendor implements the credential check. changeset rather than logged as a rename of a rename. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011HwhYb3yU3qnGjtFRodQxm
4.76.0 shipped conv_send_voice_sms_channel_test, so the rename needs its own entry rather than a correction to #706's now-consumed changeset. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011HwhYb3yU3qnGjtFRodQxm
kmonsoe
force-pushed
the
refactor/sms-channel-test-tool-name
branch
from
July 30, 2026 21:40
eb64889 to
4779ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conv_send_voice_sms_channel_test→conv_send_sms_channel_test.The send path dispatches on
capabilities.sendTest, which only Twilio and MessageBird set. Vapi and Threll both declaresendTest: false, so on a voice channel the tool has always answeredchannel vendor 'vapi' does not support test sends(channel-admin.service.ts:199) — thevoice_smsqualifier promised a path that does not exist.Its sibling
conv_test_voice_sms_channelkeeps the qualifier: all four providers implementtest, so the credential check really is voice+SMS. The pair reads asymmetrically now, which is the point — the reach differs.Also here:
conv_test_voice_sms_channelfor credentials and the dashboard's Make a test call for end-to-end.skill://conv/setup-voice-sms-channel— three references updated; the Verify section now names the error a voice channel gets.No MCP tool for placing a test voice call:
ChannelAdminService.call()stays/v1-only (conv-channels.controller.ts:112), a human-initiated real phone call.tool-naming.test.tspasses;openapi.json+ docs fixtures regenerated.Rebased onto #707, which released 4.76.0 and consumed #706's changeset — the old name shipped, so the rename carries its own changeset instead of a correction to that one.
🤖 Generated with Claude Code
https://claude.ai/code/session_011HwhYb3yU3qnGjtFRodQxm