Add Unreal Engine 5.8 support#463
Open
marekl11 wants to merge 1 commit into
Open
Conversation
UE 5.8 changed two engine APIs the plugin depended on: 1. FJsonObject keys are now UE::FSharedString (FJsonObject::FStringType) instead of FString. Iterating Values yields shared-string keys and the field interface takes FStringView, so code assuming FString keys no longer compiles. (The UE_JSONOBJECT_LEGACY_STRING_KEYS=1 escape hatch changes FJsonObject's layout and is unsafe to define only in a plugin against an installed engine, so keys are handled properly instead.) 2. StaticEnum<T>() is deleted for namespaced UENUMs such as ESIOConnectionCloseReason, breaking UEnum::GetValueAsString<T>(). Changes are engine-compatibility only; no behavioural or public API changes. - uplugin: EngineVersion -> 5.8, VersionName -> 2.12.0 - SIOJConvert: ToFStringKeyedMap() helper for the bundled converter copy; FJsonObjectWrapper round-trip via SetField; FString(*Key) in key trim/replace - SIOJsonObject::GetFieldNames: copy shared-string keys into FString array - SIOJRequestJSON / SIOMessageConvert: build FString keys from shared-string keys - SocketIONative: map ESIOConnectionCloseReason to a string for the disconnect log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UE 5.8 changed two engine APIs the plugin depended on:
FJsonObject keys are now UE::FSharedString (FJsonObject::FStringType) instead of FString. Iterating Values yields shared-string keys and the field interface takes FStringView, so code assuming FString keys no longer compiles. (The UE_JSONOBJECT_LEGACY_STRING_KEYS=1 escape hatch changes FJsonObject's layout and is unsafe to define only in a plugin against an installed engine, so keys are handled properly instead.)
StaticEnum() is deleted for namespaced UENUMs such as ESIOConnectionCloseReason, breaking UEnum::GetValueAsString().
Changes are engine-compatibility only; no behavioural or public API changes.