Skip to content

query/submissions: fetch less unnecessary data#1542

Draft
alxndrsn wants to merge 43 commits into
getodk:masterfrom
alxndrsn:less-fetching
Draft

query/submissions: fetch less unnecessary data#1542
alxndrsn wants to merge 43 commits into
getodk:masterfrom
alxndrsn:less-fetching

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented Jul 9, 2025

Closes getodk/central#

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Comment thread lib/data/odata.js Outdated
Comment thread lib/model/query/submissions.js Outdated
@alxndrsn alxndrsn changed the title query/sessions: fetch less unnecessary data query/submissions: fetch less unnecessary data Jul 9, 2025
join submission_defs on submissions.id = submission_defs."submissionId" and submission_defs.current
join forms on forms."xmlFormId"=${xmlFormId} and forms.id=submissions."formId"
join projects on projects.id=${projectId} and projects.id=forms."projectId"
join forms on forms."xmlFormId"=${xmlFormId} and forms.id=submissions."formId" and forms."projectId"=${projectId}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert - already removed in #1536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant