Update OpenRosa hash after deletion of property in ownerOnly entity list#1814
Open
matthew-white wants to merge 2 commits into
Open
Update OpenRosa hash after deletion of property in ownerOnly entity list#1814matthew-white wants to merge 2 commits into
matthew-white wants to merge 2 commits into
Conversation
46ad51d to
60df0cb
Compare
Member
Author
|
@sadiqkhoja, I've tagged you for review, since you reviewed the related PR #1522. |
Member
Author
|
@sadiqkhoja if you end up having time sometime next week to review this PR, that'd be awesome. I'd love to get this PR merged at some point soon. I have a follow-up PR planned to add a few more tests in this area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#1849.
What has been done to verify that this works as intended?
I wrote a test that failed before the fix was made.
Why is this the best possible solution? Were any other approaches considered?
I tried to follow the current pattern. I just added the new audit log action to the list of actions in the query.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I'm pretty sure that this change only affects the OpenRosa hash. I'm adding a single, specific new audit log action, so I think the risk of regression is low.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
We don't seem to document that changes to the structure of the entity list (i.e., adding or deleting entity properties) changes the OpenRosa hash of the entity list. Given that, I don't think there are any API docs that this PR needs to patch, and we don't need to mention this change in the API docs changelog. We could document this effect on the OpenRosa hash, but it feels to me like too much of a detail and doesn't need to be documented.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass, or witnessed Github completing all checks with success