Skip to content

hashPassword(): fix max-length check #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxndrsn merged 4 commits into from
Apr 30, 2026
Merged

hashPassword(): fix max-length check #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bb9aab
hashPassword(): fix max-length check
Apr 26, 2026
3217f07
Merge branch 'master' into bcrypt-length-check-correctly
alxndrsn Apr 28, 2026
89c9f34
fix tests
Apr 28, 2026
008b8f6
Merge branch 'master' into bcrypt-length-check-correctly
alxndrsn Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/util/crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const BCRYPT_COST_FACTOR = process.env.BCRYPT === 'insecure' ? 1 : 12;
const hashPassword = (plain) => {
if (typeof plain !== 'string') return reject(Problem.user.invalidDataTypeOfParameter({ value: plain, expected: 'string' }));
if (plain.length < 10) return reject(Problem.user.passwordTooShort());
if (plain.length > 72) return reject(Problem.user.passwordTooLong());
if (Buffer.byteLength(plain) > 72) return reject(Problem.user.passwordTooLong());
return isBlank(plain) ? resolve(null) : bcrypt.hash(plain, BCRYPT_COST_FACTOR);
};
const verifyPassword = (plain, hash) => ((typeof plain !== 'string' || isBlank(plain) || isBlank(hash))
Expand Down
19 changes: 19 additions & 0 deletions test/unit/util/crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,25 @@ describe('util/crypto', () => {

it('should reject given a blank plaintext', () =>
hashPassword('').should.be.rejectedWith('The password or passphrase provided does not meet the required length.'));

it('should reject given a short plaintext', () =>
hashPassword('2short').should.be.rejectedWith('The password or passphrase provided does not meet the required length.'));

it('should reject given a short plaintext (measured in bytes)', () =>
// This emoji is a single char on some devices, but in UTF-8 is 11 bytes. A
// single character is too short to use as a password, even if its byte length
// is above the password length limit.
hashPassword('👩‍💻').should.be.rejectedWith('The password or passphrase provided does not meet the required length.'));

it('should reject given a long plaintext', () =>
hashPassword('longggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg').should.be.rejectedWith('The password or passphrase provided exceeds the maximum length.'));

it('should reject given a long plaintext (measured in bytes)', () => {
const password = '❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️';
password.length.should.be.lessThan(72);
Buffer.byteLength(password).should.be.greaterThan(72);
return hashPassword(password).should.be.rejectedWith('The password or passphrase provided exceeds the maximum length.');
});
});

describe('verifyPassword()', () => {
Expand Down