You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Recording (macOS): pin the keyframe interval and count dropped frames #937
Part of #920 (ranks 17 and 18). Effort S, risk low.
Problem
The keyframe interval is left to VideoToolbox (ScreenCaptureRecorder.swift sets no AVVideoMaxKeyFrameIntervalKey). The editor's scrub cost is the GOP length; Windows uses 1 s and Linux 0.5 s.
Frames the writer input refuses (isReadyForMoreMediaData false or append failing) are dropped without a count, so no macOS lever can be measured.
Proposal
Pin the keyframe interval (1 s, like Windows) with AVVideoMaxKeyFrameIntervalKey and AVVideoMaxKeyFrameIntervalDurationKey.
Count dropped frames and report them in the helper's stop event.
Verify
Swift unit test where the logic is pure (CI swift-macos-helper).
On a Mac: ffprobe -show_entries packet=flags shows a keyframe every second; the stop event reports the drop count.
This change is assigned to the Next Release release milestone and is not necessarily available in the latest downloadable desktop release yet. It is currently marked as status: pending release until a packaged release containing it is published.
Activity
github-actions commentedon Sep 30, 2026
Fixed by #938 and merged into
main.This change is assigned to the
Next Releaserelease milestone and is not necessarily available in the latest downloadable desktop release yet. It is currently marked asstatus: pending releaseuntil a packaged release containing it is published.EtienneLescot commentedon Sep 30, 2026
Moved into
v2.0.0as part of the pre-release cut.