Repository navigation
fix(cursor): play click sounds for every clip of a recording - #1151
Conversation
clickPlacement returned on the first clip whose kept source window held the click, so a pasted copy of a take got no clicks in the export or the preview. It now places the click once per clip that keeps it, each through that clip's trims and speed regions. The preview's clip-less fallback list keeps each cue once. Fixes #1146
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No concrete issue currently blocks merging; audible confirmation of the duplicated clip’s click remains outstanding. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the bug fix: click sounds now play for every clip of a recording. |
| Description check | |
The description includes all required sections, explains the fix, links the related issue, identifies the change as a patch bug fix, and lists tests and remaining GUI export validation. |
| Linked Issues check | |
PR changes directly implement [#1146]. clickPlacement now collects every matching clip instead of returning after the first match. placedClickHits creates one hit per placement. The existing trim … |
| Out of Scope Changes check | |
The diff changes only src/lib/ai-edition/clickSound.ts and its unit tests. The implementation changes export hit placement and preview cue selection, which are required by [#1146]. The tests verify … |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
1 participant
Summary
With Mouse clicks on, a pasted copy of a recording (#1011) played no click sounds, in the export or the preview.
clickPlacementreturned on the first clip whose kept source window held the click, so each click got at most one placement. It now places the click once per clip that keeps it, each through that clip's trims and speed regions. The export's hits and the preview's per-clip buckets both read that list, so both are fixed. The preview's clip-less fallback list (used while the mounted clip id is unresolved) keeps each cue once, so one source crossing still fires it once.Candidate for cherry-pick to release/v2.1.0.
Related issue
Fixes #1146
Type of change
Release impact
Desktop impact
Screenshots / video
None, audio only.
Testing
src/lib/ai-edition/clickSound.test.ts: two clips on one take, each with its own 2x region, place a click kept by both twice at the right programme times and a click past the copy's end once; the preview fires the click over each clip and once with no clip id. The placement test fails on main.npx vitest --run src/lib/ai-edition/clickSound.test.ts,npx tsc --noEmit,npx tsc -p tsconfig.test.json --noEmit,npm run lint.