Skip to content

fix(website): Discord pill in the header, and editor captions that fit their translation - #1171

Merged
EtienneLescot merged 2 commits into
mainfrom
chore/navbar-discord-pill
Oct 13, 2026
Merged

EtienneLescot merged 2 commits into
mainfrom
chore/navbar-discord-pill

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Two small website fixes.

  • Discord in the header: a pill beside GitHub's, same style, with Discord's mark. It is a community link, so it moves out of the site's own pages on the left.
  • Editor captions overlapping the inspector: the caption slot was a fixed 118px, sized for the English captions. The French ones wrap to more lines and their last line ran under the panel. The driver now measures the tallest caption (--cap-content) and --cap-h grows to it, with the same air (23px landscape, 1px portrait). It is declared on .stage, where the driver writes the variable, since a custom property resolves where it is declared.

Checked on the docs dev server: the Discord pill renders beside GitHub (en), and in French at 1440 and 1100 px the tallest caption measures 121px, the slot becomes 144px and the panel starts below it. Not checked by eye at the exact cursor beat, only by measurement.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • The Discord link now appears on the right side of the navigation bar, opens in a new tab, and uses an inline Discord icon.
  • Bug Fixes
    • Recreation captions now have enough vertical space to display wrapped text without being constrained to a fixed height, on both desktop and portrait layouts.

A community link, so it sits with GitHub's and in the same style, not among the site's own pages on the left.
The slot was a fixed 118px, sized for the English captions. The French ones wrap to more lines, and their last line ran under the inspector panel. The driver now measures the tallest caption and --cap-h grows to it, with the same air.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6a262451-f1fa-4f2e-b701-227970b4ff24
📥 Commits

Reviewing files that changed from the base of the PR and between 912b448 and 5bbc838.

📒 Files selected for processing (3)
  • website/docusaurus.config.ts
  • website/src/components/Recreation/driver.ts
  • website/src/components/Recreation/styles.module.css

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The navbar Discord link now appears on the right as an HTML link that opens /discord/ in a new tab. Recreation stages measure caption content and use that height to set desktop and portrait caption areas.

Changes: Discord Navbar Link

Layer / File(s) Summary
Right-side Discord link
website/docusaurus.config.ts
The locale dropdown remains on the right. The Discord link is now an HTML link with an inline icon that opens the configured URL in a new tab.

Recreation Caption Sizing

Layer / File(s) Summary
Measured caption height
website/src/components/Recreation/driver.ts, website/src/components/Recreation/styles.module.css
measure sets --cap-content to the tallest caption’s height. Desktop and portrait stage styles use that value to size caption areas, with minimum heights and additional spacing.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5bbc8

The Discord link moves beside GitHub, and captions can grow to fit their content. The reported disabled-animation layout already accommodates taller captions, with no supported remaining merge risk.

Pre-merge checks · Passed 3 · Failed 2

Failed Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check Warning The description provides a clear summary and testing results, but it omits the required Related issue, Type of change, Release impact, Desktop impact, and Screenshots / video sections. The omission is… Add all missing template sections. Select the applicable Type of change, Release impact, and Desktop impact options. State the related issue or explain that none applies. Add screenshots or a video for the header and caption layout changes.
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title clearly summarizes both main website fixes: the Discord header pill and editor captions that fit translated text.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides a clear summary and testing results, but it omits the required Related issue, Type of change, Release impact, Desktop impact, and Screenshots / video sections. The omission is significant for visual website changes.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit a442c0f into main Oct 13, 2026
21 checks passed
@EtienneLescot
EtienneLescot deleted the chore/navbar-discord-pill branch October 13, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant