Repository navigation
feat(website): offer the Windows ARM64 installer on /download/ - #1315
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: adding a Windows ARM64 installer to the download page. |
| Description check | |
The description includes the summary, issue status, change type, release impact, desktop impact, and detailed testing results. It is substantially complete, although the desktop impact could more accu… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (7 skipped: 7 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description includes the summary, issue status, change type, release impact, desktop impact, and detailed testing results. It is substantially complete, although the desktop impact could more accurately select Windows and Installer / packaging, and no screenshots are provided for the UI change.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Every release since 2.1.0 ships an -arm64.exe beside the x64 one. The page now lists it under the Windows card, and the build fails if a latest release lacks it, like every other kind.
c828f34 to
371550d
Compare
1 participant
Summary
Since 2.1.0 every release ships
Openscreen.Setup.<version>-arm64.exe, and the docs now say Windows on ARM has its own installer, but/download/only offered the x64 one.release.ts: newwindowsArmpattern (/arm64\.exe$/i). The existingwindowspattern already excludes it.download.tsx: a "Windows on ARM · ARM64 · .exe · unsigned" row under the Windows card, same style as the other rows.windowsArmlike every other kind. The latest stable, v2.1.0, has the asset.windowsArminstead ofother.i18n:sync -- --accept.There is no ARM auto-detection: the page detects Windows but never reads the CPU architecture there.
Related issue
None.
Type of change
Release impact
Desktop impact
Testing
npm testinwebsite/: 42 pass. The main fixture is now the real v2.1.0 asset list, blockmaps and zsync included, and each kind resolves to exactly one asset.npm run i18n:check: up to date.npm run build: passes.build/download/index.htmllinks toreleases/download/v2.1.0/Openscreen.Setup.2.1.0-arm64.exe.🤖 Generated with Claude Code
Summary by CodeRabbit