feat: remove selected filler words by transcript ID

[auberginewly]

Summary

• Add a chat Agent tool, removeFillerWords, that accepts transcript word IDs chosen from getTranscriptWords after reading the surrounding speech.
• Resolve each ID to its recorded asset, validate its source timestamps, and require exactly one clip to contain the whole word before editing. Reject the entire request on a missing, invalid, duplicate, already-cut, or ambiguous target.
• Create non-destructive, clip-anchored trims through the existing addTrim executor and return each word, asset, clip, trim ID, and the actual stored trim span. The Agent prompt restricts use to explicit filler-word cleanup requests.
• Add tests for a repeated word whose second occurrence is meaningful, cross-asset resolution, invalid IDs/timestamps, ambiguous clips, and edit consent.

Related issue

Closes #853

Type of change

• Feature

Release impact

• Minor

Desktop impact

• Not platform-specific

Screenshots / video

No UI changes.

Testing

• fnm exec --using 22.22.1 npm run test — 263 files passed; 3342 tests passed, 2 skipped.
• fnm exec --using 22.22.1 npx tsc --noEmit — passed.
• fnm exec --using 22.22.1 npx tsc -p tsconfig.test.json --noEmit — passed.
• fnm exec --using 22.22.1 npm run lint — exit 0; 24 existing warnings elsewhere in the repository.
• git diff --check — passed.

Known limitations

• This is a chat Agent action only. It does not add a one-click cleanup UI or voice enhancement.
• Filler classification remains contextual Agent judgment. The tool refuses transcript words without trustworthy timing or a unique fully covering clip; it does not guess a range.
• Open feat: a demo is never ugly (audit integration) #814 may shape addTrim cut boundaries. This tool reports the span actually stored after that edit path rather than assuming the word's original timestamps are the final cut.

Summary by CodeRabbit

• New Features
  • Added an option to remove selected filler words from a transcript. Each selection is matched to a clip, and invalid or ambiguous selections are rejected without partial changes.
  • The AI editing tools can remove explicitly selected word occurrences, including when an asset is specified to distinguish repeated word IDs.
  • Removal respects edit-consent settings. Results report the removed words and associated trims; transcripts and clips remain intact, with only the selected occurrences trimmed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7f03401c-0d8e-4ef9-b990-aaa59000ce5c

📥 Commits

Reviewing files that changed from the base of the PR and between 9938956 and 2f847ef.

📒 Files selected for processing (3)

• electron/ai-edition/agent-tools.test.ts
• electron/ai-edition/agent-tools.ts
• electron/ai-edition/deep-agent/service.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

The agent now has a mutating tool that removes selected transcript words by ID. The tool validates each target, creates clip-specific trims, and returns the removed words and actual trim spans.

Changes

Filler-word removal

Layer / File(s)	Summary
Tool contract and agent exposure electron/ai-edition/agent-tools.ts, electron/ai-edition/deep-agent/service.ts, electron/ai-edition/deep-agent/service.test.ts, electron/ai-edition/agent-tools.test.ts	Adds the removeFillerWords schema and tool registrations. Agent guidance limits use to explicit requests and directs selection by transcript word ID with the matching asset ID.
Word validation and trim application electron/ai-edition/agent-tools.ts, electron/ai-edition/agent-tools.test.ts	Resolves requested IDs to transcript words and validates sources, timestamps, clip containment, and existing trims before applying edits. Creates a clip-specific trim for each selected word and returns removal details. Tests cover successful removal and refusal cases.
MCP tool coverage electron/mcp/openscreen-mcp-server.test.ts	Tests schema exposure, selected-word trimming, asset-scoped resolution for duplicate IDs, and refusal when edits are disabled.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Agent
  participant removeFillerWords
  participant TranscriptWords
  participant addTrim
  Agent->>removeFillerWords: Submit selected word IDs and optional asset ID
  removeFillerWords->>TranscriptWords: Resolve and validate requested words
  removeFillerWords->>addTrim: Add clip-specific trim for each validated word
  addTrim-->>removeFillerWords: Return stored trim
  removeFillerWords-->>Agent: Return removed words and trim spans

Loading

Merge Risk: ⚪ Minimal · up to 2f847

The new tool applies selected word trims without exposing partial edits when an operation fails. No actionable merge-blocking risk was established; proceed with normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to cd7e9

The new action can change a project, but it uses the existing edit-permission check and validates its targets before making cuts. No new access to other projects or services was established. How concurrent changes and interrupted saves are handled remains uncertain.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The demonstrated edit scope is the supplied project document: an allowed call can create cuts across its recorded assets where each selected word maps to one clip. No new cross-project or external-service write path was established.

Trust Boundaries and Controls

• observed — Word IDs and model-selected arguments are checked against recorded assets, valid timestamps, unique clip containment, and existing cuts before editing. Explicit user intent and filler classification are not independently checked by this executor; the known production path instead supplies the existing project-edit setting.

Resilience and Maintainability Implications

• observed — The agent wrapper advances its in-memory document only when an execution returns a document. Within the new action, unsuccessful steps do not return the locally accumulated edits.

Hardening Proposals

• proposed — If explicit filler-cleanup intent must be a separate authorization condition, pass a caller-established permission to the executor rather than relying on model instructions. Define the save-boundary behavior for stale documents and interrupted or repeated requests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the main change: removing selected filler words by transcript ID.
Description check	✅ Passed	The description covers the change, related issue, feature type, release and desktop impact, screenshots, testing, and known limitations. It provides clear validation and failure behavior.
Linked Issues check	✅ Passed	The PR meets the coding requirements in #853. removeFillerWords resolves selected word IDs to recorded assets, validates source timestamps, requires one fully covering clip, and rejects invalid, dup…
Out of Scope Changes check	✅ Passed	The changes stay within #853. Tool registration, validation, Agent guidance, and tests support the requested chat-based word-ID cleanup. The PR does not add the separate one-click UI or unrelated voic…

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}