fix(windows): end the audio track where the video ends - #946
Conversation
Every Windows take carried 0.44 to 0.58 s of audio past its video (measured on three takes of 13 to 113 s, a constant gap, so a tail). The stop sequence quiesces WGC and stops the microphone, loopback, device watcher, keep-alive and webcam before it stops the mixer, and the mixer is clock-driven: it kept writing chunks through that half second. The mixer is now paused on the stop request, the same request the video writer stops on. The pause writes what the cushion holds up to that instant and nothing after; a pause already in place is left as it is. New test: a pause followed 300 ms later by a stop ends the track at the pause (410 ms for a pause at 418, the chunk grid). Fixes #942
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
Fixes #942. Part of #920.
Cause
Change
Verified
mixer-track-ends-at-the-pause-before-a-stop: a pause followed 300 ms later by a stop ends the track at the pause (410 ms for a pause at 418 ms, the 10 ms chunk grid). Without the pause, the stop would carry it 300 ms further.audio_sample_utils_test).Pending
ffprobe -show_entries stream=codec_type,durationshould read audio and video within about one chunk (10 ms) of each other.🤖 Generated with Claude Code