Skip to content

docs(testing): log the v2.0.0-rc.13 computer-use e2e pass - #988

Merged
EtienneLescot merged 1 commit into
mainfrom
claude/e2e-computer-use-rc-tests-1df943
Oct 3, 2026
Merged

EtienneLescot merged 1 commit into
mainfrom
claude/e2e-computer-use-rc-tests-1df943

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Logs the Windows computer-use pass on v2.0.0-rc.13, scoped to the app changes since rc.8 (the last computer-use pass; the rc.13 row already logged covers the export path).

Result: Partial — 1 defect

The webcam shows its first frame when a clip is entered past the webcam's last frame from another clip. Two clips of one take (screen video 50.98 s, webcam 51.24 s, audio and clip 51.31 s): scrubbing from clip 2 to 51.2 s in clip 1 shows the screen's last frame (227b9b8 works) but the webcam's frame 0. Reproduced 2/2; correct from inside clip 1 or at 51.0 s.

Cause: open_and_seek_clip and seek_pair in crates/compositor/src/live.rs seek the webcam with seek_to and fall back to seek_to(0.0), while present_frame uses seek_to_or_last. Still on main. Paused scrub only, ~70 ms window per clip, so not a promote blocker in my view.

Passed

Driven with real OS input; observation through PrintWindow + CDP because computer-use screenshots were grey. Not run: no-camera HUD (#967), macOS HUD fix, tray, GIF, macOS/Linux.

Summary by CodeRabbit

  • Documentation
    • Added a Windows test log documenting a webcam-frame issue when seeking near the end of a clip, along with test results and observations.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (2)
technical-documentation/testing/manual-e2e-checklist.md — configured
technical-documentation/engineering/release-and-secrets.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47ea799f-145c-4ad0-8b4f-f2ee059a0bd6
📥 Commits

Reviewing files that changed from the base of the PR and between b2e8635 and 40b3e08.

📒 Files selected for processing (1)
  • technical-documentation/testing/manual-e2e-checklist.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The manual E2E checklist now records a Windows v2.0.0-rc.13 run, including a webcam frame observed when seeking near the end of a clip.

Changes

Manual E2E results

Layer / File(s) Summary
Record Windows seeking results
technical-documentation/testing/manual-e2e-checklist.md
Adds a results-log entry describing webcam seeking behavior, passed checks, additional observations, and untested areas.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: my-denia

Merge Risk: ⚪ Minimal · up to 40b3e

This update documents a reproduced seeking issue and marks the run partial; it does not change runtime behavior. No actionable merge risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 40b3e

The change affects 1 system.

Changed systems: technical-documentation

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — technical-documentation (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in technical-documentation/testing/manual-e2e-checklist.md: Added a Windows v2.0.0-rc.13 results-log row. It reports the webcam’s first-frame fallback when seeking from another clip into the final ~70 ms of a clip, while same-clip seeking and seeking to an earlier time show the correct frame; it also records passed checks, additional observations, and untested areas.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change as a documentation update that logs the v2.0.0-rc.13 computer-use E2E pass.
Description check ✅ Passed The description explains the test scope, reports the reproduced defect and passed checks, and lists the testing method and areas not tested. It provides enough detail to understand the change, though …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit 746277d into main Oct 3, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant