feat: larger default camera, 60% cap, scissors on the trim tool - #992
Conversation
The picture-in-picture camera opened at 25%, too small to read a face once a zoom shrinks it, and stopped at 50%. Existing projects keep the size they stored.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (17)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe Picture-in-Picture webcam size maximum changes from 50% to 60%, and its default changes from 25% to 40%. The Cut tool icon changes from SplitSquareHorizontal to Scissors in the video editor timeline and website tool palette. ChangesPicture-in-Picture webcam sizing
Cut tool icons
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The camera-size change preserves the newly supported range and clamps larger values when read; the Cut icon change is presentational. No actionable merge-blocking issue was identified. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change remains limited to camera layout and existing project settings. Settings reads and scene construction retain finite-value checks and size limits. No introduced security issue was identified, but native persistence recovery and direct native inputs were not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 9 files. (8 skipped: 8 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
WEBCAM_SIZE_MAX,DEFAULT_WEBCAM_SIZE_PRESET, the project default). Projects that stored a size keep it; a stored size above 60 still clamps to 60.Scissors, as on the trim lane pills and the trim inspector), mirrored in the website recreation.Tests
compositeLayout,sceneDescription,editorSettings,RightPanes.layout); the circle roundness test pins its own size instead of following the default.npm run test, bothtscconfigs andnpm run lintpass locally.🤖 Generated with Claude Code
Summary by CodeRabbit