fix(spec-6-1): wire Runs-tab ctx% (v0.10.1 patch) - #16
Merged
Merged
Conversation
…nelDeps) The Runs tab ctx% column (Surface C, Q8) never rendered end-to-end — runsRow(r, getModelContextWindow?) accepts the resolver (Task 7) but fleet-panel.ts called runsRow(r) without it, so maxContext was always undefined → ctx% segment hidden. Threading the shared getModelContextWindow fn (already wired into the FleetWidgetController in Task 11) through FleetPanelDeps so the Runs tab picks it up. Bumps 0.10.0 → 0.10.1. Found in the v0.10.0 term smoke (Runs row showed '27K tok' but no ctx%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(spec-6-1): wire Runs-tab ctx% (v0.10.1 patch)
The Runs tab
ctx%column (Surface C, Q8) never rendered end-to-end in v0.10.0.runsRow(r, getModelContextWindow?)accepts the resolver (Task 7) butfleet-panel.tscalledrunsRow(r)without it, somaxContextwas alwaysundefined→ thectx%segment was hidden. The$column was unaffected (readscostTotaldirectly offRunMeta).Fix
Thread the shared
getModelContextWindowfn (already wired into theFleetWidgetControllerin Task 11) throughFleetPanelDeps+SubagentToolDeps, pass it at the Runs-tab render call site (runsRow(r, this.deps.getModelContextWindow)).Caught by
The v0.10.0 term smoke — the Runs row showed
27K tokbut noctx%, while pi's own status bar showed1.9%/976k(proving themodelRegistry.contextWindow=976000flows). Unit tests (runs-rows.test.mts) cover the pure fn but not the panel wiring, which is why the gap slipped through Task 11 review.Tests
365/365 pass, typecheck clean. v0.10.0 → v0.10.1.