Skip to content

Test-only env vars read by shipped binaries: hide or document #1006

Closed

Description

@nick-potts

Question

Shipped binaries read PLOYZ_INGRESS_VERIFY_PORT, the health-monitor period, SSH control-persist, the upgrade release dir and the ACME directory. Once the 1.0 CLI cut lands, which of these survive? For each survivor: does it move behind a test seam, or does it become a documented operator knob?

Activity

  1. self-assigned this
    on Sep 24, 2026
  2. nick-potts commented on Sep 24, 2026

    @nick-potts
    ContributorAuthor

    Resolution

    After the 1.0 CLI cut, one of the five survives. It becomes a documented operator knob. The other four are deleted.

    Env var Read by Disposition
    PLOYZ_ACME_DIRECTORY daemon certificates Keep, documented in core/README.md: unset = Let's Encrypt production, a URL = that ACME directory, empty = issuance off. The rung-4 testkit keeps using the empty state.
    PLOYZ_INGRESS_VERIFY_PORT CLI dns/probe.rs Deleted along with the dns module (Remove Hosted DNS from the daemon, SDK and CLI).
    PLOYZ_SSH_CONTROL_PERSIST CLI connect.rs Deleted; ControlPersist=10m becomes a constant. Its only setter was build_layer3, which runs ployz deploy.
    PLOYZ_HEALTH_MONITOR_PERIOD CLI and Cloud worker (through the SDK) Deleted. The per-service update.monitor in the Deploy Intent is the only control. Tests set that or wait the default 5s.
    PLOYZ_RELEASE_DIR, ployzd install --release-dir, PLOYZ_UPGRADE_RELEASE_DIR CLI bootstrap, daemon installer and upgrade Deleted as one chain. Its only production user was qualification, which is already deleted. ReleaseSource::Local leaves the stored upgrade receipt and remains only in #[cfg(test)] for the in-process installer tests. The setup_cli.rs tests move in-process and pass the bootstrap in directly.

    Execution: Remove test-only env vars from shipped binaries; document PLOYZ_ACME_DIRECTORY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions