Repository navigation
Queue and cancel remote Builds on one Machine - #838
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6788e4921a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve FIFO queue admission and timing alongside bounded terminal reports and observed-work evidence.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 267209e3e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28b12e5aae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1ae705b9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| Ok(Ok(admission)) => admission, | ||
| Ok(Err(error)) => return failure(Stage::Admission, error), | ||
| Ok(Err(error)) => return failure(Stage::Admission, error).with_work(work), |
There was a problem hiding this comment.
When a direct local ployz build already owns the shared builder lock but no remote RPC is active, runner.enter() grants this request the active semaphore permit because that semaphore tracks only RPCs; Admission::try_acquire_with then returns Busy, and this branch immediately rejects the request instead of placing it in the Machine-local FIFO. Coordinate admission with the shared filesystem lock so local-versus-remote contention also waits within the configured queue timeout.
Useful? React with 👍 / 👎.
* feat(build): queue and cancel remote Machine builds Closes #807 * fix(build): clean abandoned builders at daemon startup * fix(build): quarantine ownership before Docker preflight * fix(build): remove abandoned uploads during clean restart --------- Co-authored-by: Codex <codex@codex-vm.tailcb9c5.ts.net>
Remote Builds now wait in a Machine-local FIFO instead of rejecting every competing request as busy. One Build runs at a time, with eight waiting slots by default; source and secrets stay on the client until admission. Machine-local policy validates queue capacity and separate queue/active timeouts.
Cancellation, disconnect and expiry remove waiters or request bounded active termination. Upload staging retains exclusive ownership through cleanup. Restart discards waiting work and attempts bounded abandoned-builder cleanup; uncertain termination keeps ownership quarantined. Progress reports the selected Machine, separate waiting/execution timings and completed versus unattempted work.
Validation:
cargo test --workspace --all-features, workspace Clippy with warnings denied, and formatting passed.Closes #807