Skip to content

Fix remote Build input isolation and image delivery - #844

Merged
nick-potts merged 1 commit into
mainfrom
fix/remote-build-followups
Sep 9, 2026
Merged

nick-potts merged 1 commit into
mainfrom
fix/remote-build-followups

Conversation

@nick-potts

Copy link
Copy Markdown
Contributor

Remote per-Service Builds could upload unrelated Services’ source and credentials, failed image verification could leave temporary image references behind, and auxiliary build tags could change the repository used by Deploy.

This follow-up to #842:

  • Copies only the selected Service’s referenced contexts, Dockerfiles, SSH keys and secrets, with its own Railpack metadata. Explicitly shared inputs and the normalized command-wide Docker configuration remain available.
  • Verifies downloaded image content before publishing the retention tag and attempts temporary-reference cleanup on every return path. Verification errors remain the reported failure; existing retention tags are preserved.
  • Binds and transfers each completed digest through the repository declared by the Service, regardless of metadata tag ordering.

Validation:

  • Rung 1: per_service_upload_contains_only_referenced_inputs, failed_digest_delivery_cleans_up_without_publishing_unverified_content, and deploy_binds_each_service_to_its_build_when_requested_tags_are_shared each failed before the fix and passed afterward. repository_reference_rejects_a_malformed_service_image covers the error boundary.
  • cargo test --workspace --locked; cargo clippy --workspace --all-targets --all-features --locked -- -D warnings; formatting and Layer 3 registration checks.
  • A startup test now explicitly creates private state permissions so it does not depend on the shell’s umask.
  • Standards: PASS. Spec: PASS. Maintainability: PASS. Simplicity: PASS.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T05:17:56.448398Z 97603ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nick-potts
nick-potts merged commit 5518adf into main Sep 9, 2026
7 checks passed
@nick-potts
nick-potts deleted the fix/remote-build-followups branch September 30, 2026 15:14
nick-potts added a commit that referenced this pull request Sep 30, 2026
Co-authored-by: Codex <codex@codex-vm.tailcb9c5.ts.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant