Feat/add gitlab mr approval controls - #423
Open
Joseph94m wants to merge 3 commits into
Open
Conversation
Joseph94m
force-pushed
the
feat/add-gitlab-mr-approval-controls
branch
from
August 20, 2026 07:18
d96ac25 to
f33e099
Compare
Joseph94m
marked this pull request as ready for review
August 20, 2026 07:52
Joseph94m
requested review from
Totara-thib,
coconux3 and
thomasboni
as code owners
August 20, 2026 07:52
Joseph94m
force-pushed
the
feat/add-gitlab-mr-approval-controls
branch
from
August 20, 2026 10:56
f33e099 to
f85cb93
Compare
Joseph94m
force-pushed
the
feat/add-gitlab-mr-approval-controls
branch
2 times, most recently
from
August 20, 2026 11:32
90ac8ab to
0688320
Compare
Joseph94m
force-pushed
the
feat/add-gitlab-mr-approval-controls
branch
from
August 20, 2026 11:46
0688320 to
8b7a80a
Compare
Joseph94m
force-pushed
the
feat/add-gitlab-mr-approval-controls
branch
from
August 20, 2026 12:01
8b7a80a to
02c5edf
Compare
Contributor
|
@Joseph94m Reviewed + tested e2e. Also checked legacy fidelity line-by-line against the backend2 controls. All of this by Claude. I've verified its results. Blocker
Nits
|
Joseph94m
force-pushed
the
feat/add-gitlab-mr-approval-controls
branch
from
August 21, 2026 15:34
ab36c42 to
f15f4b2
Compare
Collaborator
Author
|
@thomasboni should be good ! |
…ing caveat, key-rename doc, 403/404 comment wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413
Closes #414
Test on https://gitlab.com/getplumber/examples/go-test-with-hash @thomasboni