Skip to content

Adding NewRelic Datasource with count and comparison NRQL support#5711

Open
mudasirmirza wants to merge 2 commits intogetredash:masterfrom
mudasirmirza:adding_newrelic_datasource
Open

Adding NewRelic Datasource with count and comparison NRQL support#5711
mudasirmirza wants to merge 2 commits intogetredash:masterfrom
mudasirmirza:adding_newrelic_datasource

Conversation

@mudasirmirza
Copy link
Copy Markdown

@mudasirmirza mudasirmirza commented Mar 2, 2022

What type of PR is this? (check all applicable)

  • New Query Runner (Data Source)

Description

Adding NewRelic query runner. This support two types of queries, count and comparison.

Related Tickets & Documents

PR for adding DataSource documentation
getredash/website#638

Split off from: #5708

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@mudasirmirza
Copy link
Copy Markdown
Author

@susodapop as you said, this PR only adds support for NewRelic DataSource.

@susodapop susodapop added the Team Review Meets PR criteria, ready for full review label Mar 3, 2022
@guidopetri
Copy link
Copy Markdown
Contributor

@mudasirmirza , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Copy Markdown
Member

I've just solved the merge conflict (it was just a 1-liner), but there looks to be other problems that need fixing as well.

Hopefully @mudasirmirza still has the time and interest to get this PR done. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Meets PR criteria, ready for full review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants