Skip to content

ci(secret-scan): Scan pull request diffs in place - #220

Merged
geoffg-sentry merged 2 commits into
mainfrom
simplify-secret-scan
Oct 30, 2026
Merged

geoffg-sentry merged 2 commits into
mainfrom
simplify-secret-scan

Conversation

@geoffg-sentry

Copy link
Copy Markdown
Contributor

TruffleHog clones a file:// checkout a second time, and that second worktree is what runs large repos out of disk. Scan commits since the base in the checkout we already have.

TruffleHog clones a file:// checkout a second time, and that second
worktree is what runs large repos out of disk. Scan commits since the
base in the checkout we already have.

Co-Authored-By: Grok 4.7 <noreply@x.ai>
Co-authored-by: Cursor <cursoragent@cursor.com>
@geoffg-sentry
geoffg-sentry requested a review from a team as a code owner October 30, 2026 20:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8f75fae. Configure here.

Comment thread .github/workflows/secret-scan.yml Resolved
A pull request that lags its base branch does not contain the base
tip. Fetching that tip at depth 1 leaves the histories disconnected.
TruffleHog then reports "unable to resolve merge base", scans nothing,
and exits 0, so the check goes green. Pass the merge base instead.

Co-Authored-By: Grok 4.7 <noreply@x.ai>
Co-authored-by: Cursor <cursoragent@cursor.com>
@geoffg-sentry
geoffg-sentry merged commit 5c364c4 into main Oct 30, 2026
9 checks passed
@geoffg-sentry
geoffg-sentry deleted the simplify-secret-scan branch October 30, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants