Skip to content

fix(win): accept minimal PDB70 CodeView records #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 3 commits into from
Aug 20, 2026
Merged

fix(win): accept minimal PDB70 CodeView records #169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1488cd1
fix(win): accept minimal PDB70 CodeView records
jpnurmi Aug 19, 2026
8b6a5ac
fix(win): validate CodeView PDB name terminator
jpnurmi Aug 19, 2026
bfe80ce
continue
jpnurmi Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion snapshot/win/pe_image_reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ bool PEImageReader::DebugDirectoryInformation(UUID* uuid,
continue;

if (debug_directory.AddressOfRawData) {
if (debug_directory.SizeOfData < sizeof(CodeViewRecordPDB70)) {
if (debug_directory.SizeOfData <
offsetof(CodeViewRecordPDB70, pdb_name) + 1) {
Comment thread
sentry[bot] marked this conversation as resolved.
LOG(WARNING) << "CodeView debug entry of unexpected size in "
<< module_subrange_reader_.name();
continue;
Expand All @@ -200,6 +201,12 @@ bool PEImageReader::DebugDirectoryInformation(UUID* uuid,
continue;
}

if (data[data.size() - 1] != '\0') {
LOG(WARNING) << "CodeView debug entry missing NUL-terminator in "
<< module_subrange_reader_.name();
continue;
}
Comment thread
cursor[bot] marked this conversation as resolved.
Comment thread
sentry[bot] marked this conversation as resolved.

CodeViewRecordPDB70* codeview =
reinterpret_cast<CodeViewRecordPDB70*>(data.data());
*uuid = codeview->uuid;
Expand Down
Loading