Repository navigation
ref(attributes): Scrub S3 object keys by default - #713
Open
pabloDeputter wants to merge 1 commit into
Open
pabloDeputter wants to merge 1 commit into
pabloDeputter wants to merge 1 commit into
Conversation
Change scrubbing from manual to auto on `aws.s3.key`, `aws.s3.copy_source`, and `aws.s3.delete`. Keys can contain personal data, e.g. "customer/alex@example.com/invoice.pdf"; default scrubber should be applied as is done on `url.full` for example.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
If this is added, this should probably also be done on |
pabloDeputter
marked this pull request as ready for review
October 13, 2026 16:30
pabloDeputter
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
mjq and
nsdeschenes
as code owners
October 13, 2026 16:30
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Member
|
please give this 2-3 days before merging for others to take a look, thanks! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change scrubbing from manual to auto on
aws.s3.key,aws.s3.copy_source, andaws.s3.delete. Keys can contain personal data, e.g.customer/alex@example.com/invoice.pdf; default scrubber should be applied as is done onurl.fullandfile.pathfor example.(will be rebased and merged after #711 since both change
aws.s3.delete)