Repository navigation
feat(attributes): Add AWS Lambda, Step Functions and Secrets Manager name attributes - #716
pabloDeputter wants to merge 1 commit into
Conversation
…name attributes Add `aws.lambda.function.name`, `aws.step_functions.state_machine.name`, `aws.step_functions.activity.name` and `aws.secretsmanager.secret.name`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f60aee. Configure here.
| * Type for {@link _AWS_LAMBDA_FUNCTION_NAME} aws.lambda.function_name | ||
| */ | ||
| export type AWS_LAMBDA_FUNCTION_NAME_TYPE = string; | ||
| export type _AWS_LAMBDA_FUNCTION_NAME_TYPE = string; |
There was a problem hiding this comment.
Lambda constant rebound to new key
High Severity
aws.lambda.function.name normalizes to the same public constant as the existing aws.lambda.function_name key. AWS_LAMBDA_FUNCTION_NAME now means the new SDK-target name, and the old key moves to _AWS_LAMBDA_FUNCTION_NAME. Callers keep compiling but record a different attribute, and the Python deprecation warning no longer fires for the old identifier. These keys are not aliases: the old one still aliases faas.name.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 2f60aee. Configure here.


Description
Adds the following attributes (non-OTel):
aws.lambda.function.name: the function a Lambda API call acts on (GetFunction,UpdateFunctionCode, …)aws.step_functions.state_machine.nameaws.step_functions.activity.nameaws.secretsmanager.secret.name: from theNameSecrets Manager returnsWhy
Next PR (#717) in stack adds descriptions for AWS SDK spans by service, operation and resource, e.g.
SecretsManager.GetSecretValue db-password. Other services already have a short name for this (aws.s3.bucket,aws.kinesis.stream_name,faas.invoked_name). These only had the full ARN, e.g.arn:aws:secretsmanager:us-east-1:123456789012:secret:db-password-AbCdEf, which is too long and already in the respective ARN attribute.All of these resource names are already part of the ARNs we collect, so no new data is sent.