fix(mdx): Propagate ENOENT error code for missing MDX files #16038
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The root cause analysis for DOCS-9WX identified that the
Page Server Component (/[[...path]])was throwing an unhandled error when a request for a valid slug (like/changelog) was made, but the corresponding MDX source file was not found at runtime.This happened because
getFileBySlug()insrc/mdx.tswas throwing a genericErrorobject without a.codeproperty when it failed to find a source file. Thepage.tsxcomponent's catch block, however, specifically checks fore.code === 'ENOENT'to gracefully returnnotFound(). Since the error lacked this property, it was re-thrown and became an unhandled error.This fix modifies
getFileBySlug()to attachcode: 'ENOENT'to the error object when a source file cannot be found. This ensures that thepage.tsxcomponent can correctly identify and handle the "file not found" scenario, preventing unhandled errors and returning a proper 404 response.Resolves DOCS-9WX
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES