Draft
Conversation
20d2494 to
446c745
Compare
|
This is not exclusively a Sentry problem. Not sure the extra complexity is worth it here given that everyone who has telemetry setup is already going to have all of the setup calls in their Application. Additionally all of the Opentelemetry package documentations say to call setup. Technically a little cleaner, I will certainly grant you that, but maybe going to cause more pain than it is worth. |
Collaborator
Author
|
@grantwest thanks for the input. I believe it is worth the effort and a little bit of extra complexity because it helps with getting started AND hides various implementation details too, actually. Having said that, this PR will be a proposal, so I welcome all the feedback and we'll figure out if we want to proceed or not 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow-up to #886
Automatically configure OpenTelemetry SDK and instrumentation libraries when tracing is enabled, eliminating manual setup boilerplate from user applications.
Before
Users had to manually configure
config :opentelemetryand call.setup()on each instrumentation library inApplication.start/2:After
All setup is config-driven under
integrations: [opentelemetry: [...]]: