Skip to content

fix(browser): enrich graphqlClient spans for relative URLs #20296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
Closed

fix(browser): enrich graphqlClient spans for relative URLs #20296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/browser/src/integrations/graphqlClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,14 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption
return;
}

const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'];
// Fall back to the `url` attribute too: the fetch instrumentation only
// sets `url.full` / `http.url` for absolute URLs, but populates `url`
// for relative GraphQL endpoints. Without this fallback the integration
// silently skips relative endpoints. (#20292)
const httpUrl =
spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] ||
spanAttributes['http.url'] ||
spanAttributes['url'];

@cursor cursor Bot Apr 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test for relative URLs

Low Severity

This fix PR adds a fallback to spanAttributes['url'] for relative GraphQL endpoints but does not include any unit, integration, or e2e test that verifies the fix. The existing integration tests (in dev-packages/browser-integration-tests/suites/integrations/graphqlClient/) only use absolute URLs like http://sentry-test.io/foo. A regression test exercising a relative endpoint (e.g., /graphql) would confirm the fix works and prevent future regressions. Per the project review rules, fix PRs are expected to include at least one test covering the regression being fixed.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 87cc443. Configure here.

const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down
Loading