fix(tanstackstart-react): Delete only the source maps that Sentry enabled

[s1gr1d]

The default filesToDeleteAfterUpload: ['./**/*.map'] does not enter dot directories like .output, so the client source maps that Sentry enabled stayed in the build output of Nitro apps.

• Deletes the source maps in the output directory of each environment where only Sentry turned them on.
• Keeps source maps that the user enabled with build.sourcemap, an environment setting or build.rolldownOptions.output.sourcemap.
• Deletes only in the output directories of the build. The old default ./**/*.map also deleted source maps of dependencies in node_modules (npm and yarn layouts).
• Warns on Vite 7, where Sentry only knows build.outDir.

Refs #21012

[s1gr1d]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 2f5889c. Configure here.}

[JPeer264]

q: Wouldn't it be easier to add another default?

filesToDeleteAfterUpload: ['./**/*.map', './.*/**/*.map']

[s1gr1d]

Good question! Howeeever, a static glob is one decision for the whole project, while it differs per environment whether Sentry enabled the source maps.

For example, the glob would be used whenever the top-level build.sourcemap is unset, but source maps can also be enabled in e.g. nitro({ sourcemap: true }) (writes server maps to .output/server), and ./.*/**/*.map would delete them, although the user wanted them. Or also @cloudflare/vite-plugin (enables worker maps itself).

Also, the glob has no ignore list, so ./.*/**/*.map would match every dot folder in the root (.wrangler, caches, …).

Reading the output directories from the resolved config also covers Nitro presets like .vercel/output or .netlify without extra globs.

Created a PR for Nuxt to improve this: #25450

[JPeer264]

that's a great point. Let's go with the new flow then 👍

[JPeer264]

Just a general question and maybe a little broad. Is there any possibility that the output dir is either not set, or a different option can be set (or set via ENV variables)? Just asking since if this one is not set, we're not deleting any sourcemaps by default, as the default glob is gone now.

Maybe we should add a console.warn (without debug) for cases where the filesToDelete is empty?

[s1gr1d]

Is there any possibility that the output dir is not set, or set by a different option or ENV variables? … Maybe add a console.warn when filesToDelete is empty?

The output dir is always set: Vite defaults build.outDir to dist, and output.dir (e.g. Nitro's) takes precedence.
An empty filesToDelete... means Sentry enabled no source maps, so I think a warning would only be noise for users with their own settings. But I added a debug log for that case.