Repository navigation
test(tanstackstart-react): Add source map E2E app - #25363
Merged
Merged
Conversation
s1gr1d
marked this pull request as ready for review
October 14, 2026 11:59
s1gr1d
force-pushed
the
sig/tanstack-start-source-maps-e2e
branch
from
October 14, 2026 12:08
8613745 to
1d9d414
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d9d414. Configure here.
s1gr1d
commented
Oct 14, 2026
Comment on lines
+62
to
+63
| // TODO: The uploader passes the emitted file paths to `glob` as patterns, so it skips a file whose path has glob | ||
| // characters, like Nitro's `_libs/@tanstack/react-router+[...].mjs`. Remove this when the uploader matches paths literally. |
nicohrubec
approved these changes
Oct 16, 2026
s1gr1d
added this pull request to stack #25439
October 16, 2026 08:29
JPeer264
approved these changes
Oct 19, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Tests fail though because the pnpm-workspace is missing
Build a TanStack Start app with Nitro against a mock Sentry server and check the upload: the source maps carry the client and server source, their source paths are relative to the project root, every debug ID has an uploaded source map, and no source map stays in the build output. The app is optional in CI because Nitro 3 is in beta.
Both markers are in the same route file, which client and server source maps embed completely, so one uploaded map could pass both checks. Check each marker only in the source maps of the files in its output directory, matched by debug ID.
Install test-utils from the tarball, pin Playwright to 1.64.1 and add the app's pnpm-workspace.yaml.
s1gr1d
force-pushed
the
sig/tanstack-start-source-maps-e2e
branch
from
October 23, 2026 13:18
326632b to
cdd46bc
Compare
s1gr1d
enabled stacked auto-merge (squash)
October 23, 2026 13:19
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
Contributor
size-limit report 📦Compared: 9d65457 (PR test merge using develop at 6def2d7) Against: 6def2d7 (develop) · base run #63362 ✅ Baseline matches: this diff contains only this PR's changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
tanstackstart-react-sourcemapsE2E app. It builds a TanStack Start app with Nitro against a mock Sentry server and checks the upload:The app is optional in CI because Nitro 3 is in beta.
Stacked on #25360.
Refs #21012