Repository navigation
fix(v10/cloudflare): auto-instrument a re-exported default export - #25407
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
nicohrubec
added a commit
that referenced
this pull request
Oct 16, 2026
#25430) Backport of: #25343 ## Differences to the original PR - `packages/cloudflare/src/vite/transform.ts`: on v10, a local class already wrapped by a named export keeps its binding (which now points at the wrapped class), so `export { Foo as default }` stays as written instead of being re-pointed at a wrapper name. - `packages/cloudflare/src/vite/autoInstrument.ts`, tests and the `cloudflare-autoinstrument-package-entry` e2e app: small adjustments to fit v10's code layout. Heads-up: this conflicts with #25407 (backport of #25345) in `packages/cloudflare/src/vite/transform.ts` and its test. Whichever lands second needs a rebase. This branch was prepared by the v10 backport automation, which was blocked at PR creation; it's opened manually now. <!-- junior-request-attribution:start --> via **Jan Peer Stöcklmair**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:local%3Aweb%3A83fc948beed4fb12a54d41cb --> -- [View Junior Session in Sentry](https://sentry.sentry.io/explore/conversations/local%3Aweb%3A83fc948beed4fb12a54d41cb/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Nicolas Hrubec <nicolas.hrubec@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25345
Differences to the original PR
packages/cloudflare/src/vite/transform.ts: v10 doesn't havewrapDefaultSpecifier(localexport { handler as default }wrapping from fix(cloudflare): auto-instrument when wranglermainis a package #25343, which isn't on v10), and the specifier handler is still namedwrapCrossModuleSpecifier. So the!kindbranch only routesdefaultre-exports with afromclause towrapDefaultReexport; every other kind-less specifier still returnsundefinedas it did before on v10.wrapDefaultReexportitself is the same as on develop.packages/cloudflare/test/vite/transform.test.ts: added only the three re-export tests from this PR (plus the same-worker RPC binding test). The local-specifier tests from fix(cloudflare): auto-instrument when wranglermainis a package #25343 that sit next to them on develop are left out, since that behavior isn't on v10.via Junior system actor
junior.--
View Junior Session [Sentry]