Repository navigation
Conversation
logaretm
added this pull request to stack #25201
October 15, 2026 15:51
![semgrep-code-getsentry[bot]](https://avatars.githubusercontent.com/in/1153895?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 15, 2026 15:59
7fe783d to
f1e1f59
Compare
Contributor
size-limit report 📦Compared: 7f16112 (PR test merge using develop at 5f03422) Against: ca4fc32 (develop) · base run #62950
|
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 15, 2026 16:20
f1e1f59 to
ab2c887
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
2 times, most recently
from
October 15, 2026 17:15
9765090 to
9bad613
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
2 times, most recently
from
October 15, 2026 17:44
c1733f2 to
fdca10d
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 15, 2026 18:16
fdca10d to
f17f89e
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 15, 2026 18:26
f17f89e to
fadf52a
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 15, 2026 18:28
fadf52a to
e1a3c68
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 16, 2026 01:51
e1a3c68 to
305aa01
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
2 times, most recently
from
October 16, 2026 04:23
3596b0a to
ec58ad6
Compare
logaretm
force-pushed
the
awad/tunnel-nitro
branch
from
October 16, 2026 14:00
ec58ad6 to
42c2c08
Compare
logaretm
marked this pull request as ready for review
October 19, 2026 19:36
logaretm
requested review from
mydea and
s1gr1d
and removed request for
a team
October 19, 2026 19:36
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
requested review from
JPeer264 and
Lms24
and removed request for
a team
October 19, 2026 20:08
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eaaa873. Configure here.
| // up a `NUXT_APP_BASE_URL` set at runtime. | ||
| setManagedTunnelDefaults({ basePath: (useRuntimeConfig() as { app?: { baseURL?: string } }).app?.baseURL }); | ||
| const appFetch = nitroApp.fetch; | ||
| nitroApp.fetch = request => handleTunnelRequestIfMatched(request) ?? appFetch(request); |
There was a problem hiding this comment.
Tunnel runs before Cloudflare client
Medium Severity
On Nitro v3 the managed tunnel now answers from a nitroApp.fetch wrapper, which is the worker entry. handleTunnelRequestIfMatched reads the active client, but sentryCloudflareNitroPlugin still installs that client inside localFetch. Tunnel POSTs can miss the match and fall through to app middleware, so the Cloudflare path this branch is meant to cover never serves the tunnel.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit eaaa873. Configure here.
Contributor
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Contributor
Optional E2E testsAll optional checks were successful. 58 successful. See the run. Successful checks
|
…iddleware On Nitro v3, Nuxt and `@sentry/nitro` put the tunnel check first in h3's middleware list, since Nitro runs the app's `server/middleware` before anything a module registers and has no public way to go first. On Nitro v2, Nuxt answers from the `request` hook.
…oute rules can't skip it
… rules don't run after it
…yCloudflareNitroPlugin
…lts so Cloudflare clients start with it
`nuxt dev` opens the port before it can serve and answers 503 until then, while Playwright only waits for the port.
…rop the variants the base path ones cover
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Nitro app's own
server/middleware, like an auth check, ran before anything Sentry registered and would block tunnel requests, fixed by putting the tunnel check first in h3's middleware on Nitro v3 and answering from therequesthook on Nitro v2.This is the one framework PR where the ordering matters, so worth a closer look. Nuxt picks the right plugin based on the Nitro version, and the base path comes from Nitro's
baseURL.The e2e tunnel variants for Nuxt 4, Nuxt 5 and Nitro 3 check that the tunnel answers while an auth middleware rejects every other POST.
For reviewers: if you need an overview of what this is, refer to #25199.
closes #20254