Repository navigation
Conversation
logaretm
added this pull request to stack #25201
October 15, 2026 16:13
Contributor
size-limit report 📦Compared: 72b0363 (PR test merge using develop at d6a317b) Against: ca4fc32 (develop) · base run #62950
|
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 15, 2026 16:20
419b8a2 to
af3e293
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 15, 2026 16:38
af3e293 to
b435f51
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 15, 2026 17:15
b435f51 to
e098356
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 15, 2026 17:36
e098356 to
6da24a1
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
2 times, most recently
from
October 15, 2026 18:16
769b893 to
3bb11c2
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
2 times, most recently
from
October 15, 2026 18:28
2a02a85 to
d8aa95d
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 16, 2026 01:51
d8aa95d to
4f1d836
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 16, 2026 02:25
4f1d836 to
1a12598
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
2 times, most recently
from
October 16, 2026 04:23
8b4b976 to
fa4e4a1
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 16, 2026 14:00
fa4e4a1 to
f26216a
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 19, 2026 17:08
858fbd8 to
38bcb62
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 19, 2026 17:34
38bcb62 to
7359cd2
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
2 times, most recently
from
October 19, 2026 18:22
713f920 to
ed31689
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 19, 2026 18:36
ed31689 to
a1efbf8
Compare
logaretm
force-pushed
the
awad/tunnel-remix
branch
from
October 19, 2026 19:12
a1efbf8 to
97d83fb
Compare
logaretm
marked this pull request as ready for review
October 19, 2026 19:37
logaretm
requested review from
chargome and
s1gr1d
and removed request for
a team
October 19, 2026 19:37
Contributor
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Contributor
s1gr1d
approved these changes
Oct 23, 2026
Comment on lines
+29
to
+32
| const tunnelResponse = handleTunnelRequestIfMatched(context.request); | ||
| if (tunnelResponse) { | ||
| return tunnelResponse; | ||
| } |
Member
There was a problem hiding this comment.
A general idea: you added the tunnel in sentryRemixMiddleware but createRequestListener runs earlier, so we could put the tunnel logic there.
wdyt?
Member
Author
There was a problem hiding this comment.
I think it makes sense, currently it didn't cover apps without a router.
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 7 failing, 57 successful. See the run.
Successful checks
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 53b7826. Configure here.
| // of the router could answer the tunnel. Its auth middleware rejects the POSTs that get through. | ||
| if (!process.env.E2E_TEST_PLAIN_SERVER) { | ||
| expect((await page.request.post('/anything', { data: 'x' })).status()).toBe(403); | ||
| } |
There was a problem hiding this comment.
Conditional assertion in tunnel test
Low Severity
Flagged because the review guidelines ask to split a test that uses a conditional for different paths. The E2E_TEST_PLAIN_SERVER branch only asserts the pre-router 403 in one variant, so a failure on that path is easy to miss or misread as a skip.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 53b7826. Configure here.
Sentry's middleware is already prepended to every `createRouter`, so it now answers tunnel requests before route matching and the app's own middleware.
…re the app's own handler
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the tunnel wiring to the remix SDK. We already had a middleware so it works by adding the request matching logic there.
The
remix-v3tunnel variant covers it.For reviewers: if you need an overview of what this is, refer to #25199.
closes #25464