Repository navigation
Conversation
The required Cloudflare integration test job keeps the wrangler and `@cloudflare/vite-plugin` versions of the package. A new optional job runs the same steps with the latest versions of both, so a new wrangler or workerd release shows up in CI early but cannot block a PR. Like the optional E2E tests, it does not run on release branches. The two jobs share their steps through a YAML anchor. The runner starts `wrangler dev` on 127.0.0.1, because with the latest wrangler `localhost` connects over IPv6 and changes the captured client address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
marked this pull request as ready for review
October 19, 2026 09:08
JPeer264
requested review from
isaacs and
mydea
and removed request for
a team
October 19, 2026 09:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional CI job that runs the Cloudflare integration tests with the latest
wranglerand@cloudflare/vite-plugin. The required job stays on the pinned versions (wrangler 4.86.0), so an older runtime stays tested. Like the optional E2E tests, the new job cannot block a PR and does not run on release branches.The runner now starts
wrangler devon127.0.0.1, because with the latest wranglerlocalhostconnects over IPv6 and changes the captured client address.Why
New runtime features, for example
Span.spanContext()in workerd 1.20261009.1, need a new wrangler to be tested. A bug in a new wrangler release must not block PRs.CI decisions
The optional job reuses the steps of the required job through a YAML anchor. Anchors are new in this repo. The alternative is to copy the 5 steps.