Repository navigation
test(browser): Fix flaky long task, pageload cancellation and CLS timing assertions - #25518
Merged
Merged
Conversation
mydea
marked this pull request as ready for review
October 19, 2026 14:08
mydea
requested review from
Lms24 and
logaretm
and removed request for
a team
October 19, 2026 14:08
mydea
force-pushed
the
test/browser-flaky-timing-bounds
branch
from
October 21, 2026 12:03
904bb39 to
90735d9
Compare
Contributor
size-limit report 📦Compared: 6169fa5 (PR test merge using develop at d4a4e81) Against: ca4fc32 (develop) · base run #62950
|
…ing assertions Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
force-pushed
the
test/browser-flaky-timing-bounds
branch
from
October 21, 2026 15:25
90735d9 to
79a6f1e
Compare
Lms24
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These browser integration tests showed up in last week's flaky test report. Each one failed on
developbecause of a timing assertion that was too strict for loaded CI runners.ui.long_taskspan. Sometimes that was an unrelated pageload task (~50–65ms), so the test failed the 0.1s lower bound. They now use the longest span, which is the blocking script.reportPageLoadednavigation: the pageload span started at time origin, but init's 1ssetTimeoutcan run late (1.59s seen in CI). The bound is now 2.5s, the point wherereportPageLoaded()would have ended the span. The finish reason is still asserted to becancelled.via Francesco Gringl-Novy.
--
View Junior Session [Sentry]