Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 2b6976d (PR test merge using develop at e17a480) Against: e17a480 (develop) · base run #63967 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 66 successful. See the run.
Successful checks
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-after-upload
branch
from
October 22, 2026 10:45
04eb117 to
1e975bd
Compare
timfish
marked this pull request as ready for review
October 22, 2026 10:51
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-after-upload
branch
from
October 22, 2026 11:49
1e975bd to
1c26acc
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-after-upload
branch
2 times, most recently
from
October 28, 2026 12:15
4c367d6 to
98521e9
Compare
timfish
requested review from
chargome,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 28, 2026 12:15
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 98521e9. Configure here.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-after-upload
branch
from
October 28, 2026 12:53
98521e9 to
b5daca9
Compare
…nd staged uploads Adds the option, a decision helper that maps the user's source map setting to enable and delete choices, and an upload staging folder on the build plugin manager that bundler plugins can fill from their pre-write hooks. No bundler plugin uses it yet, so build output does not change.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-after-upload
branch
from
October 28, 2026 14:49
b5daca9 to
fd30f6b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of a stack that lets the bundler plugins handle source maps without any user configuration (#25609). Today a user has to set the bundler's source map mode to hidden and write
filesToDeleteAfterUploadglobs, and wrong globs leave maps in production or delete files that were never uploaded. The follow-up PRs wire each bundler plugin to the pieces added here; this one changes no build output.The new
sourcemaps.deleteSourcemapsAfterUploadoption defaults to "auto": the plugin removes source maps only when it turned them on itself,truealso removes maps the user enabled, andfalsekeeps the plugin from changing or warning about the user's setting at all. A small decision helper maps the user's source map setting onto "enable hidden maps" and "delete after upload", and warns when maps are turned off or inlined. The option also lands on the sharedSourceMapsOptionstype in core, so the framework SDKs can expose it later.The plugin manager gains an upload staging folder that a bundler plugin fills from its pre-write hook with each chunk and its map, before the bundler drops the map from its output.
uploadSourcemapsuploads the staging folder together with whatever it finds on disk, in the prepared mode and in the directprepareArtifacts: falsemode alike, keeps the folder with an error log when the upload fails since it holds the only copy of the maps, and now reports whether it uploaded anything.