Repository navigation
ci: Stop uploading duplicate tarballs to the release artifact - #25688
Merged
Merged
Conversation
andreiborza
approved these changes
Oct 23, 2026
Contributor
size-limit report 📦Compared: 987e22f (PR test merge using develop at 6df508e) Against: 6df508e (develop) · base run #63271 ✅ Baseline matches: this diff contains only this PR's changes.
|
JPeer264
approved these changes
Oct 23, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Uffs that's a lot of MB to download. Thx for fixing
mydea
reviewed
Oct 23, 2026
| with: | ||
| name: ${{ github.sha }} | ||
| retention-days: 90 | ||
| # Do not use `packages/**/*.tgz`: it follows the workspace links in `node_modules` and uploads duplicate tarballs. |
Member
There was a problem hiding this comment.
i think this comment is redundant likely?
Member
Author
There was a problem hiding this comment.
Why redundant? Without it, there's no info about why this glob has to look like it does now and not have the /**/ lookup.
Member
There was a problem hiding this comment.
I am personally up for both. On the one hand you see that right away, on the other hand the git history and PR has more info. IMO both are valid - I'll also vote more for an inline comment as this is increasing the artifact quite a lot
Member
There was a problem hiding this comment.
Maybe we can rephrase it to watch out for deeper globs and warn
Member
Author
There was a problem hiding this comment.
Or I just add an exclusion, that's self-explaining and not just a comment:
!${{ github.workspace }}/packages/**/node_modules/**
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 63 successful. See the run.
Successful checks
|
s1gr1d
enabled auto-merge
October 23, 2026 09:47
s1gr1d
added a commit
that referenced
this pull request
Oct 23, 2026
(cherry picked from commit 7fb94b4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the move to pnpm, the
packages/**/*.tgzglob in the release artifact upload also follows the workspace links inpackages/*/node_modules.The 11.9.0 artifact grew from 31 MB to 689 MB, with 852 tarballs instead of 47 (433 copies of
sentry-core-11.9.0.tgz).Craft publishes every matching tarball in parallel. That crashed the publish runner after only
@sentry/corewent out. Check out the runs: getsentry/publish#9980This PR changes the glob to
packages/*/*.tgz, which matches only the tarball in each package folder.