Repository navigation
chore: Replace Volta with pnpm-managed node versions - #25689
Open
sentry-junior[bot] wants to merge 11 commits into
Open
sentry-junior[bot] wants to merge 11 commits into
sentry-junior[bot] wants to merge 11 commits into
Conversation
…tal) Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
reviewed
Oct 23, 2026
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
size-limit report 📦Compared: e38756a (PR test merge using develop at e1026aa) Against: e1026aa (develop) · base run #63365 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 61 successful. See the run.
Successful checks
|
…pied app Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
…to-sentry The pin came in with the app in #25331 without a stated reason and was already older than the repo's node version at the time, so the app now uses the root pin. Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
s1gr1d
reviewed
Oct 23, 2026
Link the pnpm install docs instead of repeating them, move PATH checks and the Volta migration into a troubleshooting section, and fix the SAM image comments, which claimed the node 20 default matched the root pin.
mydea
reviewed
Oct 23, 2026
Move how node and pnpm versions are managed, the PATH check and the Volta migration into a short section at the end, and drop the updating-versions part.
mydea
reviewed
Oct 23, 2026
mydea
reviewed
Oct 23, 2026
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
changed the title
sentry-junior
Bot
requested review from
andreiborza,
chargome,
isaacs,
logaretm and
s1gr1d
and removed request for
a team
October 23, 2026 11:33
…pnpm-node-runtime # Conflicts: # packages/esbuild-plugin/package.json # packages/vite-plugin/package.json Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
JPeer264
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volta is unmaintained and can't start pnpm 11+ (volta-cli/volta#2114), so today we start pnpm 10 through Volta, and pnpm 10 then switches to pnpm 12. pnpm 12 can pin node itself: its global
nodeshim runs the version from the nearestdevEngines.runtime(project-aware global bins). That means node is inherited from the rootpackage.json, and any package or E2E app can override it with its own entry. Novolta.extendsboilerplate is needed anymore.pnpm itself: it stays pinned in
packageManager, which is already the source of truth for pnpm. Any pnpm run in the repo downloads that version and switches to it, so a contributor's global pnpm only needs to be pnpm 12+, because thenodeshim needs it. Workspace packages always use the root pnpm, since one workspace means one install.CONTRIBUTING.mdcovers the one-time setup (install pnpm, thenpnpm runtime set node 24 -g) and a migration path for Volta users. Contributors who do nothing keep Volta's default node, and pnpm only works for them if Volta has a default pnpm.Notes on the non-obvious choices:
onFail: "warn", not"download". Withdownload, pnpm adds node to the lockfile and puts it innode_modules/.bin, so everypnpm runwould use the pinned node even in the CI node-version matrix. Withwarn, nothing goes into the lockfile, and CI keeps using the node fromsetup-node.copyToTempresolves the nearestdevEngines.runtimeandpackageManagerfrom the app up to the repo root and writes both into the copiedpackage.json, replacing thevolta.extendsrewrite. On CI, the E2E jobs set up node a second time from the copiedpackage.json; this takes well under a second when the version is already installed. Locally,run.mjsno longer needsvolta run node.node-version-file: package.jsonkeep working unchanged, becausesetup-nodereadsdevEngines.runtimeonce thevoltafield is gone.node-openai-decisions-send-to-sentrypinned node 24.15.0 for no documented reason, so it now uses the root version. No E2E app overrides node or pnpm anymore.Not verified: how Nx, IDE test runners and git hooks behave with pnpm's
nodeshim.via Francesco Gringl-Novy.
--
View Junior Session [Sentry]