Skip to content

fix(core): Respect header collection for session user agents - #25871

Merged
msonnb merged 1 commit into
developfrom
ms/session-user-agent-collection
Oct 29, 2026
Merged

fix(core): Respect header collection for session user agents#25871
msonnb merged 1 commit into
developfrom
ms/session-user-agent-collection

Conversation

@msonnb

@msonnb msonnb commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Why: Sessions still automatically collected the browser's User-Agent when dataCollection.httpHeaders.request disabled or filtered it for events and spans. Apply the same filtering to sessions while preserving explicitly supplied session options.

Related to #25843

@msonnb @codex
fix(core): Respect header collection for session user agents
48b8d6b 
Co-Authored-By: OpenAI Codex <codex@openai.com>
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 59c99f4 (PR test merge using develop at b364030)

Against: b364030 (develop) · base run #64096

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.42 kB +0.08% +24 B 🔺
@sentry/browser - with treeshaking flags 28.52 kB +0.08% +21 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 28.43 kB +0.1% +27 B 🔺
@sentry/browser (incl. Tracing) 52.68 kB +0.05% +26 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.69 kB +0.05% +25 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.61 kB +0.05% +26 B 🔺
@sentry/browser (incl. Tracing, Replay) 92.94 kB +0.05% +46 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.54 kB +0.05% +36 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 97.67 kB +0.05% +46 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 110.64 kB +0.05% +46 B 🔺
@sentry/browser (incl. Feedback) 47.98 kB +0.06% +28 B 🔺
@sentry/browser (incl. sendFeedback) 35.5 kB +0.09% +30 B 🔺
@sentry/browser (incl. FeedbackAsync) 40.6 kB +0.07% +27 B 🔺
@sentry/browser (incl. Metrics) 31.42 kB +0.08% +23 B 🔺
@sentry/browser (incl. Logs) 31.7 kB +0.07% +22 B 🔺
@sentry/browser (incl. Metrics & Logs) 32.38 kB +0.08% +25 B 🔺
@sentry/react 32.21 kB +0.05% +14 B 🔺
@sentry/react (incl. Tracing) 54.94 kB +0.01% +4 B 🔺
@sentry/vue 38.7 kB +0.07% +25 B 🔺
@sentry/vue (incl. Tracing) 55.56 kB +0.04% +17 B 🔺
@sentry/svelte 30.44 kB +0.08% +22 B 🔺
@sentry/remix (Remix 3 client bundle) 57.72 kB +0.03% +14 B 🔺
CDN Bundle 32.14 kB +0.1% +32 B 🔺
CDN Bundle (incl. Tracing) 53.18 kB +0.07% +37 B 🔺
CDN Bundle (incl. Logs, Metrics) 34.35 kB +0.14% +47 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 55.11 kB +0.05% +25 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 75.8 kB +0.05% +37 B 🔺
CDN Bundle (incl. Tracing, Replay) 91.33 kB +0.04% +31 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.3 kB +0.05% +38 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 97.45 kB +0.02% +17 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.47 kB +0.04% +30 B 🔺
CDN Bundle - uncompressed 94.56 kB +0.11% +96 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 157.55 kB +0.06% +90 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.12 kB +0.1% +96 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.52 kB +0.06% +90 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.67 kB +0.05% +96 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 279.24 kB +0.04% +90 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.19 kB +0.04% +90 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 292.94 kB +0.04% +90 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 298.88 kB +0.04% +90 B 🔺
@sentry/nextjs (client) 57.81 kB +0.04% +23 B 🔺
@sentry/sveltekit (client) 53.13 kB +0.04% +16 B 🔺
@sentry/core/server 44.34 kB - -
@sentry/core/browser 13.95 kB - -
@sentry/node 155.13 kB +0.04% +52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.67 kB - -
@sentry/node - without tracing 95.88 kB +0.07% +59 B 🔺
@sentry/node - without channel injection 135.77 kB +0.05% +56 B 🔺
@sentry/aws-serverless 104.04 kB +0.06% +59 B 🔺
@sentry/cloudflare (withSentry) - minified 198.01 kB - -
@sentry/cloudflare (withSentry) 491.83 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 218.59 kB - -

View base workflow run

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 6 not successful, 51 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry (latest) Test (optional) Failing after 3m Details
❌ CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Failing after 16s Details
❌ CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Failing after 3m Details
❌ CI: Optional E2E Tests / E2E node-openai-send-to-sentry (latest) Test (optional) Failing after 4m Details
❌ CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Failing after 13s Details
❌ CI: Optional E2E Tests / E2E node-mastra Test (optional) Failing after 14s Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 42s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 19s Details
✅ CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 56s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 33s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 23s Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 46s Details
✅ CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E node-eve Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 41s Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions Test (optional) Successful in 17s Details
✅ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 51s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Successful in 36s Details
✅ CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 24s Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions (latest) Test (optional) Successful in 16s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 55s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 28s Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) Successful in 29s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Successful in 42s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 25s Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Successful in 25s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 58s Details
✅ CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 22s Details

@msonnb
msonnb marked this pull request as ready for review October 29, 2026 11:00
@msonnb
msonnb requested review from a team as code owners October 29, 2026 11:00
@msonnb
msonnb requested review from Lms24, andreiborza, chargome, isaacs, logaretm and nicohrubec and removed request for a team October 29, 2026 11:00
@msonnb
msonnb merged commit 90c1ebb into develop Oct 29, 2026
717 of 726 checks passed
@msonnb
msonnb deleted the ms/session-user-agent-collection branch October 29, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicohrubec nicohrubec nicohrubec approved these changes
@andreiborza andreiborza andreiborza approved these changes
@logaretm logaretm Awaiting requested review from logaretm logaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@isaacs isaacs Awaiting requested review from isaacs isaacs is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@chargome chargome Awaiting requested review from chargome chargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msonnb @nicohrubec @andreiborza