Repository navigation
perf(ci): Speed up tarball packing - #25979
Draft
nicohrubec wants to merge 4 commits into
Draft
nicohrubec wants to merge 4 commits into
nicohrubec wants to merge 4 commits into
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
size-limit report 📦Compared: 932019d (PR test merge using feat/speed-up-nextjs-16-e2e at bafef5a) Against: de967f7 (feat/speed-up-nextjs-16-e2e) · base run #64463
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 not successful, 51 successful. See the run.
Successful checks
|
Co-Authored-By: OpenAI Codex <codex@openai.com>
Preserve the Angular output directory and Ember prepack manifest entry. Co-Authored-By: OpenAI Codex <codex@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc14a28. Configure here.
| "build:dev:watch": "pnpm run build:watch", | ||
| "build:transpile:watch": "ng build --configuration production --watch", | ||
| "build:tarball": "npm pack ./build", | ||
| "build:tarball": "pnpm --dir build pack --pack-destination ..", |
There was a problem hiding this comment.
Angular tarball written to wrong directory
High Severity
pnpm --dir build pack --pack-destination .. is not equivalent to npm pack ./build. --pack-destination is resolved against the process cwd (packages/angular), so .. writes sentry-angular-*.tgz into packages/ instead of packages/angular/. Artifact upload (packages/*/*.tgz), E2E tarball discovery, and clean:tarballs all miss that path, so Angular is omitted from CI artifacts and releases.
Reviewed by Cursor Bugbot for commit dc14a28. Configure here.
pnpm runs prepack before creating the archive without retaining the hook in the published manifest. Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Tarball preparation delays every E2E app. Increasing packing concurrency from 5 to 8 and switching to
pnpm packreduces packing from 48s to 5s and the tarball job from 1:02 to 25s, saving another 45s of required CI time (2m36s / 35% in total including the nextjs test speedups).64cc7a4)30660ae)dc14a28)Unsure about:
There are some minor changes to the packaged tarballs, but all of these probably don't matter or might even be improvements (e.g. including licenses in packages where they were missing atm). List of tarball changes courtesy of codex:
repositorychanges from a URL string to a{ type, url }object.build:tarballnow references pnpm.prepack; the build hook still runs before packing.