Repository navigation
feat(cron): Support failure_issue_threshold and recovery_threshold in MonitorConfig - #3174
Open
ammadakram wants to merge 1 commit into
Open
ammadakram wants to merge 1 commit into
ammadakram wants to merge 1 commit into
Conversation
… MonitorConfig Fixes getsentry#2668 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2668
What changed
Sentry::Cron::MonitorConfignow acceptsfailure_issue_thresholdandrecovery_threshold(Sentry's monitor-config names for failure/recovery tolerance), exposes them as accessors, and includes them in#to_h(nil values are omitted as before). They work withfrom_crontab/from_interval, sosentry_monitor_check_inspicks them up.No global defaults were added to
Cron::Configuration; happy to add those if wanted.Tests
bin/test --gem sentry-ruby spec/sentry/cron/monitor_config_spec.rb spec/sentry/cron/monitor_check_ins_spec.rb— 36 examples, 0 failuresArgumentError: unknown keywords) and passes with it.mise run linton the changed files — no offenses.AI assistance
Claude helped draft the change and tests; the diff was reviewed and tests run locally.
🤖 Generated with Claude Code