Repository navigation
fix(attribute-values): Return values for sentry.trace_id - #8628
Conversation
Discussed impl irl with Praj, but for product rationale: When doing autocomplete for traces in the UI, it returns empty trace values. We already offer filter behaviour on the 'trace' keyword which is sent as `sentry.trace_id` then picked up by the map and pointed at the trace column. Trace is the _only_ column not backed by an attribute that we care about enumerating right now. Other columns like session_id are promoted from attributes anyway.
| class NormalizedColumn(NamedTuple): | ||
| column_name: str | ||
| types: Sequence[AttributeKey.Type.ValueType] | ||
| in_attribute_maps: bool = True |
There was a problem hiding this comment.
I don't like this name, but I also don't have a better name.
There was a problem hiding this comment.
None of the options my robot gave me feels like too big of an improvement over this either :(. Dumping it's suggestions here incase anything speaks to you.
a few options for NormalizedColumn.in_attribute_maps:
is_attribute_backed — clearest if this describes how the column is stored
uses_attribute_map — concise, a bit implementation-focused
requires_attribute_map_lookup — clearest if it controls query behaviori’d pick is_attribute_backed; it captures why trace_id is the exception without tying the name to a particular lookup.
There was a problem hiding this comment.
is_attribute_backed is better I think
Co-authored-by: Praj Bhandari <pbhandari@pbhandari.ca>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@k-fish looks like the old behaviour was baked into sentry tests. You'll need to fix that for our CIs to be green. https://github.com/getsentry/snuba/actions/runs/40913056194/job/123588046210?pr=8628. |
Discussed impl irl with Praj, but for product rationale:
When doing autocomplete for traces in the UI, it returns empty trace values. We already offer filter behaviour on the 'trace' keyword which is sent as
sentry.trace_idthen picked up by the map and pointed at the trace column.Trace is the only column not backed by an attribute that we care about enumerating right now. Other columns like session_id are promoted from attributes anyway.
UI right now:
