Repository navigation
feat(allocation-policies): Tag decision metrics with org_id and project_id - #8629
Merged
Merged
Conversation
Co-Authored-By: Dani Ezzeddine <dani.ezzeddine@sentry.io>
pbhandari
reviewed
Oct 29, 2026
pbhandari
approved these changes
Oct 29, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3735280. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The allocation policy decision metrics (
db_request_rejected,db_request_throttled,db_request_pardoned) were tagged withreferrer, plus the base tagsstorage_key,is_enforcedandpolicy_class, but nothing that identifies the org or project. So we couldn't tell from Datadog whether a specific org was having queries rejected. This came up while checking whether org4507549068099584in DE was rejected after the bytes-scanned limit change.This adds
org_idandproject_idtags, taken fromtenant_ids, to all three decision metrics inAllocationPolicy.get_quota_allowance. Missing values becomeno_org_id/no_project_id, matching the existingno_referrerfallback. Allowed queries emit no decision metric, so nothing changes there.Cardinality: these are now per-org, and per-project where a project is present, on every throttled, rejected or pardoned query. Throttled is the most frequent of the three, so watch Datadog custom-metric usage after deploy.
The base-policy tests now assert the new tags on the rejected, throttled and pardoned metrics. I couldn't run the tests locally because my sandbox has no Redis or Python 3.10+, so this relies on CI.
--
View Junior Session [Sentry]