Repository navigation
Conversation
…jectingPolicy Replace the four *_scan_limit_override param configs with one scan_limit setting (per-tenant values go in match blocks) and a key_by setting that picks the tenant the scan window counts against. The default key_by keeps today's Redis key. project_referrer_scan_limit and organization_referrer_scan_limit still apply when scan_limit is unset, so config can move in either order.
Member
Author
|
Combined into #8642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BytesScannedRejectingPolicy encodes the tenant level in six scan-limit setting names. This replaces the four param overrides with one
scan_limitsetting, pluskey_byto pick which tenant the window counts against.scan_limit: one limit for project- and org-keyed queries. Per-tenant values go in match blocks. Unset (-1) falls back toproject_referrer_scan_limit/organization_referrer_scan_limit, so config can move in either order.key_by:tenant_referrer(default, today's Redis key),organization_referrerororganization.referrer_all_projects_scan_limit_override,referrer_all_organizations_scan_limit_override,organization_referrer_scan_limit_override,organization_scan_limit_override. No config sets them today.key_byallowed as a string on policies.No behaviour change with current config.