Skip to content

ref(allocation-policies): Hard-code the concurrency shard factor to 1 - #8636

Closed
dezzeddi wants to merge 1 commit into
masterfrom
dani/concurrent-drop-shard-factor
Closed

dezzeddi wants to merge 1 commit into
masterfrom
dani/concurrent-drop-shard-factor

Conversation

@dezzeddi

Copy link
Copy Markdown
Member

rate_limit_shard_factor is a config on every concurrency policy (CRL, DCRL, RGR, XO). It is not set in any region, so it is always 1. This removes the config and hard-codes 1.

  • No behaviour change: 1 is the current value everywhere. A different value would move every count to new Redis keys, so it isn't something to tune per policy.
  • The global rate_limit_shard_factor option used by snuba/state/rate_limit.py is untouched.
  • max_query_duration_s stays as is.

rate_limit_shard_factor is a per-policy config on every concurrency policy
but is not set in any region. Remove the config and use 1.
@dezzeddi

Copy link
Copy Markdown
Member Author

Combined into #8643.

@dezzeddi dezzeddi closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant