Repository navigation
Conversation
…e bytes policies BytesScannedRejectingPolicy and BytesScannedWindowAllocationPolicy each built the same Redis sliding-window check and record calls. Move them, with the window constants and the rate limiter, into a BaseBytesScannedPolicy. Window keys, request sizes, limits and decisions are unchanged.
Member
Author
|
Combined into #8642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BytesScannedRejectingPolicy (BSR) and BytesScannedWindowAllocationPolicy (BSW) each build the same Redis sliding-window calls: a check that asks how much of the window is left, and a record of the bytes a query used.
This moves that bookkeeping into
BaseBytesScannedPolicy(_granted_bytes,_record_bytes), with the shared 10-minute window constants and rate limiter. Both policies now extend it.Zero behaviour change: every window key, request size, limit, config name and decision stays the same. Each policy still decides which window a query counts against and what to do over the limit.