Repository navigation
meta(cli): Use Craft's versioning.files instead of the bump script - #1825
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Craft 3.8.0 can write the release version into extra files during its automatic bump and postReleaseBump, so the CLI workspace no longer needs a custom preReleaseCommand. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Craft 3.8.0 adds
versioning.files(getsentry/craft#955, which closes getsentry/craft#948, filed with toolkit as the example). A release unit can now list extra files for Craft's automatic version bump, andpostReleaseBumpwrites them too. The CLI workspace used a custompreReleaseCommandonly because that option didn't exist, and that command turned off the automatic bump.What moved where:
packages/cli/package.json: Craft's npm target already bumps it once thepreReleaseCommandis gone.packages/mcp-server/package.json, the Claude plugin'splugin.json(withstripPrerelease: true, so it staysX.Y.Zon-devversions), and the version frontmatter in the CLI skill'sSKILL.mdandreferences/*.mdare nowversioning.filesentries in.craft.yml.packages/cli/script/bump-version.tsand its test are gone. The release docs and the comment in the mcp-server bundle script now point at.craft.yml.minVersiongoes from 3.7.0 to 3.8.0. Craft requires that forversioning.files, and Craft rejects a config that sets bothversioning.filesandpreReleaseCommand.Craft's file matching is strict: it fails
craft prepareif a path matches nothing or a matched file has no version to update. Every file inreferences/has exactly oneversion:frontmatter line, so the glob is safe. The skill copies underapps/cli-docs/public/.well-known/skills/andpackages/cli/.cursor/skills/are symlinks to the plugin skill, so they need no entries.I ran
craft prepare --dry-run --workspace packages/cliwith Craft 3.8.0 for99.0.0and99.1.0-dev.0. Both changed the same 45 files, and only their version lines.plugin.jsongot99.1.0for the prerelease.via @BYK.
--
View Session in Sentry