Repository navigation
ref(mcp): Call shared cron monitor endpoints and time range helpers - #1839
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sentry-junior
Bot
force-pushed
the
ref/shared-monitor-endpoints
branch
from
November 3, 2026 10:34
d30e62a to
87aca79
Compare
sentry-junior
Bot
force-pushed
the
ref/shared-monitor-endpoints
branch
from
November 3, 2026 10:47
87aca79 to
d6d764b
Compare
BYK
approved these changes
Nov 3, 2026
Base automatically changed from
ref/shared-dashboard-release-endpoints
to
main
November 3, 2026 11:12
Moves the cron monitor endpoints and SentryApiService's time range helpers (statsPeriod, start/end, and StatsMixin since/until) into toolkit-core's shared API client, as is. SentryApiService calls them. Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
ref/shared-monitor-endpoints
branch
from
November 3, 2026 11:14
d6d764b to
53800c9
Compare
BYK
added a commit
that referenced
this pull request
Nov 3, 2026
Task 8.4 of the shared API client plan ([#1669](#1669)). This is stacked on #1839. This moves the uptime monitor endpoints from `SentryApiService` into `toolkit-core`'s `api-client/endpoints/uptime-monitors`. `SentryApiService` calls them with its Zod schemas. The code moves as is. - `listUptimeMonitors` takes a numeric `projectId`, since the endpoint filters by ID. `SentryApiService` still looks the project slug up first. - `getUptimeMonitor` and `listUptimeMonitorChecks`. The checks list still defaults to 24 hours unless a range is given, through `defaultStatsPeriod` from #1839. - `createUptimeMonitor` and `updateUptimeMonitor` share one field list, so the body still holds every field that is set (an explicit `null` included), in the same order as before. - `deleteUptimeMonitor` still counts a 404 as already deleted. `@sentry/api` has no uptime operations at all, so these wrappers stay hand-written. **One change in behaviour:** as with #1741, a response that fails its schema now throws the shared `ApiResponseValidationError` instead of a `ZodError`. Checked with `pnpm run tsc`, `pnpm run lint`, `pnpm run docs:check`, and the toolkit-core, mcp-core, mcp-server bundle, and mcp-cloudflare tests (run on the top of the stack, the replay branch at `73bfc0b3`, before the later rebases), plus the uptime tool tests on this commit. <!-- junior-request-attribution:start --> via @BYK. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent%3Ab061171f2ec2e6cf6f09a6828cadc9fa --> -- [View Session](https://junior-prod.sentry.dev/conversations/agent%3Ab061171f2ec2e6cf6f09a6828cadc9fa) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3Ab061171f2ec2e6cf6f09a6828cadc9fa/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 8.4 of the shared API client plan (#1669). This is stacked on #1838.
This moves the cron monitor endpoints and the time range helpers from
SentryApiServiceintotoolkit-core's shared API client.SentryApiServicecalls them with its Zod schemas. The code moves as is.api-client/time-params:normalizeStatsPeriod,parseStatsPeriod,applyTimeParams(statsPeriodor astart/endpair), andapplyStatsMixinTimeParams(thesince/untilsecondsStatsMixinendpoints read). It rejects a range that sets both a period and dates, or only one end.defaultStatsPeriodholds the check-in list's "24 hours unless a range is given" default, which the uptime-check list reuses in the next PR. Most otherSentryApiServicemethods still call these helpers; they now import them fromtoolkit-core.endpoints/monitors:listMonitors,getMonitor(organization or project route),deleteMonitorEnvironment(a 404 still counts as already deleted),listMonitorCheckIns, andgetMonitorStats.@sentry/apihas no operation for monitor stats or for deleting a monitor environment, so those wrappers stay hand-written.One change in behaviour: as with #1741, a response that fails its schema now throws the shared
ApiResponseValidationErrorinstead of aZodError.Checked with
pnpm run tsc,pnpm run lint,pnpm run docs:check, and the toolkit-core, mcp-core, mcp-server bundle, and mcp-cloudflare tests.via @BYK.
--
View Session [Sentry]